Skip to content

Fix CONNACK IndexError #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2019
Merged

Fix CONNACK IndexError #5

merged 1 commit into from
Aug 16, 2019

Conversation

brentru
Copy link
Member

@brentru brentru commented Aug 16, 2019

rc reads 3 bytes, not 4. The 3rd byte is the error code, referenced by CONNACK_ERRORS

Pre-PR:

b'\x02\x00\x05'
Traceback (most recent call last):
  File "code.py", line 121, in <module>
  File "/lib/adafruit_iotcore/adafruit_iotcore.py", line 121, in connect
  File "/lib/adafruit_minimqtt.py", line 284, in connect
IndexError: bytes index out of range

Post-PR:

4132.02: DEBUG - Receiving CONNACK packet from broker
b'\x02\x00\x05'
Traceback (most recent call last):
  File "code.py", line 121, in <module>
  File "/lib/adafruit_iotcore/adafruit_iotcore.py", line 121, in connect
  File "/lib/adafruit_minimqtt.py", line 284, in connect
MMQTTException: Connection Refused - Unauthorized

@brentru brentru added the bug Something isn't working label Aug 16, 2019
@brentru brentru requested a review from a team August 16, 2019 17:15
@brentru brentru merged commit 25b344a into adafruit:master Aug 16, 2019
@brentru brentru deleted the fix-connack-exception branch August 16, 2019 17:18
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 16, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@9869a7c)
7054328 
Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to v1.1.1 from v1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#5 from brentru/fix-connack-exception
rtwfroody pushed a commit to rtwfroody/Adafruit_CircuitPython_MiniMQTT that referenced this pull request Sep 18, 2022
@brentru
Merge pull request adafruit#5 from brentru/fix-connack-exception
0928212 
Fix CONNACK IndexError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentru @ladyada