Fix CONNECT for large MQTT payloads #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remaining length used by
connect
is incompatible with large payloads (>127 bytes). An instance of this is when a long (> 300 byte) password, such as a JSON Web Token, or a long client identifier is provided.keepalive
value sent byconnect()
increased to 60 seconds to ensure the MQTT broker rejects incorrect connections, instead of hanging_wait_for_msg()
.connect
renamed to correct names per the MQTT spec.Tested with a PyPortal running CircuitPython Latest, two tests were run to verify compatibility with existing (small) payloads and large connect payloads...
MiniMQTT Example - Adafruit IO WiFi - testing small (<127 byte) connect payload.
Connecting to Google's Cloud IoT MQTT Server - testing large (512B+) connect payload.