add some type annotations to adafruit_minimqtt.py #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
requested changes
Feb 27, 2023
There was a problem hiding this comment.
Thank you for working on this @vladak! as well as all of the other improvements you've been making to this library.
I had a look over this and found a few things that I think we will want to change.
I'm also going to try it out on a device, I'll report back here with the results. Ordinarily types shouldn't change functionality at all, but there are a few cases I want to double check.
|
For now, I am done with the changes, unless more issues are found. Will save the more complicated stuff (Callables in particular) till next time. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 7, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_floppy to 1.0.7 from 1.0.6: > Merge pull request adafruit/Adafruit_CircuitPython_floppy#9 from adafruit/pinouts Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.3.2 from 7.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#158 from vladak/type_annotations_mqtt Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds more type annotations.
mypy --strict adafruit_minimqtt/adafruit_minimqtt.pycurrently below 100 errors (down from 168).Approaches #92.