add type hints to matcher.py #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekktrik
requested changes
Jan 6, 2023
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 17, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303_Accel to 1.1.17 from 1.1.16: > Merge pull request adafruit/Adafruit_CircuitPython_LSM303_Accel#16 from tcfranks/main > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.1.3 from 7.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#137 from vladak/type_hints_matcher Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change approaches #92, specifically for
matcher.py. After thatmypycomplains only about the function parameters/assignment:This is my first time adding type hints to Python code and have to say, being used to strongly typed language, that it feels a bit strange - retrofitting type specification that is still limping, e.g. the case of
Noneor missing function type parameters. That said, here you go.