Skip to content

remove extraneous debuggin's #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2020
Merged

remove extraneous debuggin's #8

merged 1 commit into from
Nov 15, 2020

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Nov 15, 2020

No description provided.

@ladyada ladyada requested a review from makermelissa November 15, 2020 01:52
FoamyGuy
FoamyGuy approved these changes Nov 15, 2020
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this successfully with SimpleClock code. Definitely think it's a good idea to turn off the network printing.

@ladyada ladyada merged commit 7a0b303 into adafruit:main Nov 15, 2020
jerryneedell
jerryneedell reviewed Nov 15, 2020
View reviewed changes
Copy link

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I was concerned about the password printing.

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 15, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@b176fea)
70e3cf1 
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.9.4 from 2.9.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#98 from kmatch98/blank_text

Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#8 from ladyada/main
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#7 from makermelissa/main
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#6 from ladyada/main
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#3 from makermelissa/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.8.1 from 1.8.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#53 from jepler/circuitpython-compat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryneedell jerryneedell jerryneedell left review comments

@FoamyGuy FoamyGuy FoamyGuy approved these changes

@makermelissa makermelissa Awaiting requested review from makermelissa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ladyada @FoamyGuy @jerryneedell