Refactored to use PortalBase #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makermelissa
changed the title
|
One other thing to note is I removed the IL0373 init code since it is now built into CircuitPython and that just makes the library that much bigger. It also makes it so this library isn't as tied to a specific model of MagTag. |
tannewt
approved these changes
Dec 8, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 8, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 1.4.0 from 1.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#35 from makermelissa/refactor Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_FakeRequests, Adafruit_CircuitPython_PortalBase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12. This is failing on PortalBase not being released yet and will need to be rerun after it is released.