Skip to content

return the index of the textbox created by add_text #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2020
Merged

return the index of the textbox created by add_text #29

merged 2 commits into from
Dec 2, 2020

Conversation

slootsky
Copy link
Contributor

@slootsky slootsky commented Nov 29, 2020 •
edited
Loading

This allows developer to receive the index of the textbox which was just created.

Usage:

dateBox=magtag.add_text(blahblahblah)
timeBox=magtag.add_text(blahblahblah)
...various code...

magtag.set_text('the date',dateBox)
magtag.set_text('the time',timeBox)

makermelissa
makermelissa requested changes Nov 30, 2020
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change and this will work good with some of the changes I have planned. However, it looks like it needs to be black formatted (spaces around the - at a guess) before I can merge it.

makermelissa
makermelissa approved these changes Dec 2, 2020
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@makermelissa makermelissa merged commit 31c664c into adafruit:main Dec 2, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 3, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@8c05aa5)
17c6a9e 
Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 1.1.2 from 1.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#29 from slootsky/feature/return_index_of_textbox

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 1.9.6 from 1.9.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#53 from slootsky/feature/return_id_of_textbox
@slootsky slootsky deleted the feature/return_index_of_textbox branch December 10, 2020 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slootsky @makermelissa