Handle bad indices in the json_path #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
reviewed
Nov 24, 2020
adafruit_magtag/network.py
Outdated
| @@ -139,7 +139,7 @@ def json_traverse(json, path): | |||
| for x in path: | |||
| try: | |||
| value = value[x] | |||
| except TypeError as error: | |||
| except (TypeError, KeyError) as error: | |||
There was a problem hiding this comment.
Do you want IndexError as well? I think that would cover lists. KeyError is for dicts I believe.
There was a problem hiding this comment.
Thanks, I'll add that too.
ladyada
approved these changes
Nov 24, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 25, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_INA260 to 1.2.4 from 1.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_INA260#14 from SaintGimp/fix-count-constants Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.13.1 from 0.13.0: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#42 from FoamyGuy/magtag_example Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 1.1.1 from 1.0.6: > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#25 from makermelissa/main > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#26 from adafruit/rename-example > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#24 from makermelissa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_ProgressBar to 1.3.5 from 1.3.4: > Merge pull request adafruit/Adafruit_CircuitPython_ProgressBar#19 from FoamyGuy/magtag_example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It currently handles bad names, but not indices. This fixes it.