MIDI controller numbers can be 0-127 #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Mar 9, 2019
|
great work! |
|
Thank you, I'm making baby steps! I'm really looking forward to making a control surface using the full resolution of the analog inputs on the Grand Central to control the instruments on my Mac. John Park's tutorial inspired me but now I'm gonna use more bits per potentiometer! :-) Oh, and much larger knobs. ;-) |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 10, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#6 from coreyostman/controller-number-doc
kevinjwalters
pushed a commit
to kevinjwalters/Adafruit_CircuitPython_MIDI
that referenced
this pull request
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original documentation state controller numbers must be 0-15, but it's actually 0-127 for MIDI. There are many controllers in MIDI that are 14-bit and are made up of two packets of 7-bits, one MSB, one LSB. For example, controller 20 is the MSB and controller 52 is the LSB.