Removing the original method per MIDI message (event) API #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 26, 2019 19:57
…f new send() method for class based messages. Updating examples in README.rst and midi_simpletest2.py, removing midi_simpletest.py. adafruit#12
|
Sorry we missed this! Please have the new simpletest2 as simpletest otherwise Adabot will be unhappy. |
|
@tannewt I did the rename. |
tannewt
requested changes
Oct 30, 2019
docs/examples.rst
Outdated
| .. literalinclude:: ../examples/midi_simpletest.py | ||
| :caption: examples/midi_simpletest.py | ||
| .. literalinclude:: ../examples/midi_simpletest2.py | ||
| :caption: examples/midi_simpletest2.py |
There was a problem hiding this comment.
This needs to be changed back as well.
There was a problem hiding this comment.
Done, I've been away from the CP library world for too long so missed this!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 19, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 2.1.5 from 2.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#73 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#72 from dherrada/master > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#70 from dcbriccetti/tilt-instrument Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.5.1 from 3.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_GPS#37 from kattni/setup-py-update Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 2.0.5 from 2.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#17 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#16 from 2bndy5/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Debouncer to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_Debouncer#12 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_Debouncer#11 from dastels/master Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 3.3.6 from 3.3.5: > Merge pull request adafruit/Adafruit_CircuitPython_HID#41 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_HID#42 from adafruit/revert-40-alternate-devices-for-ble > Merge pull request adafruit/Adafruit_CircuitPython_HID#40 from dhalbert/alternate-devices-for-ble Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#13 from kevinjwalters/master > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#16 from adafruit/dherrada-patch-1
sommersoft
pushed a commit
to sommersoft/Adafruit_CircuitPython_MIDI
that referenced
this pull request
Jan 9, 2020
…based on @tannewt advice. Updating all the examples to explicitly set midi_in or midi_out to the USB ports. Adding test case as constructor now raises an error if midi_in and midi_out are both omitted. This will make sphinx-build work but that appears to be a separate bug. adafruit#13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adafruit_midi/__init__.pyREADME.rstandmidi_simpletest2.pyto just use new API, deletedmidi_simpletest.pyas it purely used old API and other example replaces it.Note comments on #12 for approval of this API removal from an impacted guide author.