Add type annotations #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekktrik
requested changes
Aug 10, 2022
adafruit_max1704x.py
Outdated
| """Whether there is an active alert to be checked""" | ||
| return self._alert_status | ||
|
|
||
| @property | ||
| def alert_reason(self): | ||
| def alert_reason(self) -> bool: |
There was a problem hiding this comment.
Looks like this should be an int since it returns a number representing all the bits that define the reason for an alert.
|
Fixed the type from |
Closed
Closed
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 12, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX1704x to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_MAX1704x#5 from sokratisvas/add-type-annotations Updating https://github.com/adafruit/Adafruit_CircuitPython_SI1145 to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_SI1145#10 from caternuson/iss9 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_MAX1704x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.