Skip to content

Update spinner.py #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2018
Merged

Update spinner.py #47

merged 1 commit into from
Sep 9, 2018

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Sep 8, 2018

No description provided.

@ladyada ladyada requested a review from a team September 9, 2018 02:57
@ladyada
Copy link
Member Author

ladyada commented Sep 9, 2018

fix for #46
@kevinjwalters looks good?

@kevinjwalters
Copy link

kevinjwalters commented Sep 9, 2018

Looks good but the same problem exists in examples/spinner_advanced.py which also needs the fix.

Copy link

@kevinjwalters kevinjwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is good but also needs applying to examples/spinner_advanced.py

@ladyada
Copy link
Member Author

ladyada commented Sep 9, 2018

thanks will do that one next :)

@ladyada ladyada merged commit 3576f80 into master Sep 9, 2018
tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 2, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 2.0.4 from 2.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#42 from dhalbert/frozen-order

Updating https://github.com/adafruit/Adafruit_CircuitPython_Crickit to 2.1.2 from 2.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Crickit#10 from dhalbert/frozen-order
  > ignore the board module imports in .pylintrc

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 4.3.3 from 4.3.2:
  > Update spinner_advanced.py
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#47 from adafruit/ladyada-patch-2

Updating https://github.com/adafruit/Adafruit_CircuitPython_Thermistor to 3.2.1 from 3.2.0:
  > ignore the board module imports in .pylintrc

Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 2.2.6 from 2.2.5:
  > ignore the board module imports in .pylintrc

Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 3.3.0 from 3.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#27 from dhalbert/gui-alt-key-aliases

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 1.3.2 from 1.3.1:
  > ignore the board module imports in .pylintrc
@evaherrada evaherrada deleted the ladyada-patch-2 branch June 21, 2021 14:00
@evaherrada evaherrada restored the ladyada-patch-2 branch June 21, 2021 14:00
@evaherrada evaherrada deleted the ladyada-patch-2 branch June 21, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants