Skip to content

use milliseconds instead to support smaller boards #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2020
Merged

use milliseconds instead to support smaller boards #63

merged 4 commits into from
Aug 12, 2020

Conversation

rhooper
Copy link

@rhooper rhooper commented Aug 12, 2020

Addresses #62

@rhooper rhooper requested a review from caternuson August 12, 2020 15:20
@caternuson
Copy link

Looks good. One suggested cosmetic code tweak. Sort of a deja vu feeling - I did pretty much these same mods yesterday, made this easy to review :)

Tested on Trinket M0 with a basic blink, and it works.

@rhooper
Copy link
Author

rhooper commented Aug 12, 2020

Hmm - Tested with 6.x and get No long integer support

@rhooper
Copy link
Author

rhooper commented Aug 12, 2020

@caternuson can you look again?

@caternuson
Copy link

I tested with 5.3.1. But seeing same with 6.0 alpha 2. I'm guessing this a bug in current 6.x build. I've asked the devs. Stay tuned....

Adafruit CircuitPython 6.0.0-alpha.2 on 2020-07-23; Adafruit Trinket M0 with samd21e18
>>> import time
>>> dir(time)
['__name__', 'localtime', 'mktime', 'monotonic', 'monotonic_ns', 'sleep', 'struct_time', 'time']
>>> time.monotonic()
90.376
>>> time.monotonic_ns()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NotImplementedError: No long integer support
>>> 

@caternuson
Copy link

So...sounds like it's a behavior change for 6.x. Instead of not having the methods present, they will be present but throw an exception.

So I guess the import logic needs to change accordingly.

@caternuson
Copy link

Related:
adafruit/circuitpython#2812

@rhooper
Copy link
Author

rhooper commented Aug 12, 2020

The latest version in this branch should work on Trinket M0 on 5.3.1 and 6.0.0-latest (6.0.0-alpha.0-556-g3197c579e-dirty)

@caternuson
Copy link

@rhooper OK, grabbed latest. Yep, works now.

@rhooper
Copy link
Author

rhooper commented Aug 12, 2020

@caternuson Looking for an approval to merge

@rhooper rhooper merged commit 2d229b6 into adafruit:master Aug 12, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants