-
Notifications
You must be signed in to change notification settings - Fork 45
use milliseconds instead to support smaller boards #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks good. One suggested cosmetic code tweak. Sort of a deja vu feeling - I did pretty much these same mods yesterday, made this easy to review :) Tested on Trinket M0 with a basic blink, and it works. |
Hmm - Tested with 6.x and get |
@caternuson can you look again? |
I tested with 5.3.1. But seeing same with 6.0 alpha 2. I'm guessing this a bug in current 6.x build. I've asked the devs. Stay tuned.... Adafruit CircuitPython 6.0.0-alpha.2 on 2020-07-23; Adafruit Trinket M0 with samd21e18
>>> import time
>>> dir(time)
['__name__', 'localtime', 'mktime', 'monotonic', 'monotonic_ns', 'sleep', 'struct_time', 'time']
>>> time.monotonic()
90.376
>>> time.monotonic_ns()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
NotImplementedError: No long integer support
>>> |
So...sounds like it's a behavior change for 6.x. Instead of not having the methods present, they will be present but throw an exception. So I guess the import logic needs to change accordingly. |
Related: |
The latest version in this branch should work on Trinket M0 on 5.3.1 and 6.0.0-latest (6.0.0-alpha.0-556-g3197c579e-dirty) |
@rhooper OK, grabbed latest. Yep, works now. |
@caternuson Looking for an approval to merge |
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Button to 1.4.0 from 1.3.4: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#23 from FoamyGuy/use_extended_group Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.4.1 from 2.4.0: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#63 from rhooper/refactor-to-ms
Addresses #62