Skip to content

Fix comet length and simplification #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 1, 2020
Merged

Fix comet length and simplification #35

merged 6 commits into from
Jun 1, 2020

Conversation

rhooper
Copy link

@rhooper rhooper commented May 31, 2020

Fixes #27 and addresses other concerns in comet. Also adds an intensity calculation helper to color.

@rhooper rhooper requested a review from a team May 31, 2020 18:22
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice reduction in code size!

@rhooper
Copy link
Author

rhooper commented Jun 1, 2020

@dhalbert I added a note about why the code is the way it is.

@dhalbert
Copy link
Contributor

dhalbert commented Jun 1, 2020

Thanks. There's a little pylinting to do:

Run pylint $( find . -path './adafruit*.py' )
************* Module adafruit_led_animation.animation.comet
adafruit_led_animation/animation/comet.py:51:0: R0902: Too many instance attributes (13/11) (too-many-instance-attributes)
adafruit_led_animation/animation/comet.py:51:0: R0902: Too many instance attributes (13/11) (too-many-instance-attributes)
adafruit_led_animation/animation/comet.py:51:0: R0902: Too many instance attributes (13/11) (too-many-instance-attributes)
adafruit_led_animation/animation/comet.py:51:0: R0902: Too many instance attributes (13/11) (too-many-instance-attributes)
adafruit_led_animation/animation/comet.py:51:0: R0902: Too many instance attributes (13/11) (too-many-instance-attributes)
adafruit_led_animation/animation/comet.py:51:0: R0902: Too many instance attributes (13/11) (too-many-instance-attributes)
************* Module adafruit_led_animation.color
adafruit_led_animation/color.py:85:4: R1705: Unnecessary "elif" after "return" (no-else-return)

@dhalbert dhalbert merged commit baa8095 into adafruit:master Jun 1, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comet length bugs
2 participants