Skip to content

Add 16, 24, and 32-bit bmp support #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

makermelissa
Copy link
Collaborator

I needed this to make bitmaptools more useful. Tested on a MatrixPortal S3 with 16, 24, and 32-bit BMPs.

@makermelissa makermelissa requested a review from a team August 3, 2023 22:56
Copy link
Contributor

@matt-land matt-land left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice. Thank you Melissa!

@makermelissa
Copy link
Collaborator Author

Thanks. :). It was based on some code I wrote about 4 years ago and had placed in https://github.com/adafruit/Adafruit_CircuitPython_RA8875/blob/main/examples/ra8875_bmptest.py

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

These resources give me a much better understanding of how the data is stored.

My image working without it must have been a fluke.

I think my version of Gimp must be different or having some differences caused by something else in my environment. I tried using the export configurations shown in your screen shot but I am still facing the same issue of bitmask compression unsupported: 3

However I do think this looks good and nice to have for usage with bitmaptools. Thanks for adding this functionality!

@makermelissa
Copy link
Collaborator Author

Thanks. I'll see if it's easy enough to add that extra functionality in a separate PR.

@makermelissa makermelissa merged commit 4a2f5a6 into adafruit:main Aug 7, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 8, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.6.0 from 3.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BME680#56 from patcher-ms/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 1.18.0 from 1.17.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#71 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_USB_Host_Descriptors

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants