Created an example that uses displayio #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deshipu
approved these changes
Mar 16, 2019
examples/ili9341_simpletest.py
Outdated
| display_bus = displayio.FourWire(spi, command=tft_dc, chip_select=tft_cs) | ||
| except ValueError: | ||
| displayio.release_displays() | ||
| display_bus = displayio.FourWire(spi, command=tft_dc, chip_select=tft_cs) |
There was a problem hiding this comment.
nitpick: I wonder if we could call release_displays always (maybe catch the exception if it fails) and then not have to repeat the bus initialization.
There was a problem hiding this comment.
That's a good nitpick. I changed it to do that.
|
It appears to be failing on Travis because sphinx can't find anything on displayio. It might be because this is extending an internal class or because CP is still in beta. Either way, my changes don't touch the file it is having issues with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a working simpletest example. Tested successfully with CircuitPython 4.0-beta4, the 2.4" TFT FeatherWing, and a Feather M4 Express. It should also work with earlier versions of CP4, but that is untested.