Skip to content

Add example and lint #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Add example and lint #1

merged 2 commits into from
Aug 26, 2019

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Aug 21, 2019

No description provided.

@tannewt tannewt requested a review from a team August 21, 2019 02:23
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks.

@makermelissa makermelissa merged commit 2ca7c25 into adafruit:master Aug 26, 2019
@makermelissa
Copy link
Collaborator

I realized there is no display-ruler.bmp in the examples and I used it off the IL0373 PR. Is this something we want to add to the examples?

@tannewt
Copy link
Member Author

tannewt commented Aug 27, 2019

Ya, I think we want to add it. I'm not sure what the bundle will do with multiple repos bringing in the same file. It'd be ok if they just shared the one.

@makermelissa
Copy link
Collaborator

Maybe we can add a note into the example file that tells the user where to find it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants