for RESTful API #42
Closed
for RESTful API #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
requested changes
Mar 19, 2023
Comment on lines
+25
to
+27
| if self.path[-1] == '*': | ||
| prepath = self.path[0:len(self.path)-1] | ||
| return self.method == other.method and other.path.startswith(prepath) |
There was a problem hiding this comment.
Simpler. You could also use self.path.rstrip("*") instead of self.path[0:-1]`
Suggested change
| if self.path[-1] == '*': | |
| prepath = self.path[0:len(self.path)-1] | |
| return self.method == other.method and other.path.startswith(prepath) | |
| if self.path.endswidth("*"): | |
| return self.method == other.method and other.path.startswith(self.path[0:-1]) |
There was a problem hiding this comment.
Overwriting eq method this way, it can lead to situations where A == B but B != A.
I have been thinking for a while about wildcards in URLs, already working on a more functional approach to this, that will also allow parsing those values.
There was a problem hiding this comment.
Overwriting eq method this way, it can lead to situations where A == B but B != A.
i agree with @michalpokusa's caution about this -- I wasn't sure whether it was something standard in server routing.
Merged
|
I agree with @michalpokusa 's #43. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible to implement a RESTful API.
for example,
PUT /RGB/YELLOWPUT /RGB/GREENPUT /RGB/<any_color>We can define these APIs in one handler.
@server.route("/RGB/*", method=HTTPMethod.PUT)Thank you in advance for your consideration.