Adding cors headers messes up content-type and content-length

[mandar1jn]

Given the following object:

headers = {
    "Access-Control-Allow-Headers": "*",
    "Access-Control-Allow-Origin": "*",
    "Access-Control-Allow-Methods": "GET,POST,DELETE"
}

And the following server function:

@server.route("/api/v1/info", HTTPMethod.GET)
def info(request):
    """Return info"""
    try:
        obj = {"version": Api.api_version, "name": Api.api_name}
        response = json.dumps(obj)
        return HTTPResponse(status=CommonHTTPStatus.OK_200, body=response, content_type=MIMEType.TYPE_JSON, headers=Api.headers)
    except:
        return HTTPResponse(status=CommonHTTPStatus.BAD_REQUEST_400, headers=Api.headers)

The content-type gets turned to octet-stream and the content-length gets set to 1024.

doing this in the response.py code in the _construct_response_bytes function works fine:

headers.setdefault("Access-Control-Allow-Headers", "*")
headers.setdefault("Access-Control-Allow-Origin", "*")
headers.setdefault("Access-Control-Allow-Methods", "*")

this is a temporary solution, but not very preferred. I have looked around in the code and I have no idea what causes this issue

[mandar1jn]

because of this comment, I tried using lowercase names for the headers and this fixes the issue. I'll leave this issue open as this is probably a library issue

[mandar1jn]

Okay. The headers are now somewhat correct. Sadly, it looks like the content length header is always set to 38 even when the content is longer or shorter, resulting in cut off json strings

[mandar1jn]

Update: the content-length header is locked to the length of the first response. Currently circumventing this with a patch to response.py that replaces with headers.setdefault("Content-Length", content_length or len(body)) with headers["Content-Length"] = content_length or len(body). This is usable for us since we don't require the content length to be set in the headers object but this might not work in other cases