update pre-commit conifiguration to avoid using the local escape hatch #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
approved these changes
Oct 21, 2021
|
related: @theendlessriver13 can you help us out with improving future pre-commit files over in cookiecutter-adafruit-circuitpython? |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 26, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.9.3 from 3.9.2: > add docs link to readme > Merge pull request adafruit/Adafruit_CircuitPython_GPS#71 from theendlessriver13/update-pre-commit Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L0X to 3.4.0 from 3.3.7: > add docs link to readme > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#32 from caternuson/iss31 > Globally disabled consider-using-f-string pylint check > Moved default branch to main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_Debouncer to 1.3.12 from 1.3.11: > add docs link to readme > Merge pull request adafruit/Adafruit_CircuitPython_Debouncer#31 from tjpeden/patch-1 > Added pylint disable for f-strings in tests directory > Globally disabled consider-using-f-string pylint check > Moved default branch to main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 5.1.3 from 5.1.2: > add docs link to readme > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#94 from dhalbert/socket-arg-fix > Globally disabled consider-using-f-string pylint check Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.10.1 from 1.10.0: > add docs link to readme > Merge pull request adafruit/Adafruit_CircuitPython_Requests#82 from dhalbert/socket-arg-list > Globally disabled consider-using-f-string pylint check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using
repo: localin pre-commit is considered an escape hatch, since it is not really portable and relies on the user to have the tools installed. pre-commit provides all the configuration options to be able to achieve what was previously done in bash, also much faster, since the files are now checked in parallel.I also run autoupdate and had to fix one pylint import error, where afterwards black did some formatting, where I personally don't agree on, but it's at least consistent 😄
We might also consider enabling pre-commit.ci instead of running it in gha, it's a CI tool build for pre-commit which is really fast, auto fixes formatting issue e.g. if a PR comes in a an black was not used, it applies it and commits the changes for you. the autoupdate is run weekly (can be configured differently) and a PR is created if there are newer version of the linters or code formatters.
Since pre-commit seems to be the default in all adafruit repos this might be an option for the whole organization?