Skip to content

Change latitude and longitude parsing to return degs/mins rather than decimal degrees #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Change latitude and longitude parsing to return degs/mins rather than decimal degrees #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions adafruit_gps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,14 @@ def _parse_degrees(nmea_data):
# Where ddd is the degrees, mm.mmmm is the minutes.
if nmea_data is None or len(nmea_data) < 3:
return None
raw = float(nmea_data)
deg = raw // 100
minutes = raw % 100
return deg + minutes/60
# NMEA lat/long data comes in as 'ddmm.mmmm' for lat or 'dddmm.mmmm' for long
if nmea_data[5] == ".":
degrees = int(nmea_data[:3])
minutes = float(nmea_data[3:])
else:
degrees = int(nmea_data[:2])
minutes = float(nmea_data[2:])
return [degrees, minutes]

def _parse_int(nmea_data):
if nmea_data is None or nmea_data == '':
Expand Down Expand Up @@ -187,13 +191,15 @@ def _parse_gpgga(self, args):
secs, 0, 0, -1))
# Parse latitude and longitude.
self.latitude = _parse_degrees(data[1])
if self.latitude is not None and \
if self.latitude[0] is not None and \
self.latitude[1] is not None and \
data[2] is not None and data[2].lower() == 's':
self.latitude *= -1.0
self.latitude[0] *= -1.0
self.longitude = _parse_degrees(data[3])
if self.longitude is not None and \
if self.longitude[0] is not None and \
self.longitude[1] is not None and \
data[4] is not None and data[4].lower() == 'w':
self.longitude *= -1.0
self.longitude[0] *= -1.0
# Parse out fix quality and other simple numeric values.
self.fix_quality = _parse_int(data[5])
self.satellites = _parse_int(data[6])
Expand Down Expand Up @@ -228,13 +234,15 @@ def _parse_gprmc(self, args):
self.fix_quality = 1
# Parse latitude and longitude.
self.latitude = _parse_degrees(data[2])
if self.latitude is not None and \
if self.latitude[0] is not None and \
self.latitude[1] is not None and \
data[3] is not None and data[3].lower() == 's':
self.latitude *= -1.0
self.latitude[0] *= -1.0
self.longitude = _parse_degrees(data[4])
if self.longitude is not None and \
if self.longitude[0] is not None and \
self.longitude[1] is not None and \
data[5] is not None and data[5].lower() == 'w':
self.longitude *= -1.0
self.longitude[0] *= -1.0
# Parse out speed and other simple numeric values.
self.speed_knots = _parse_float(data[6])
self.track_angle_deg = _parse_float(data[7])
Expand Down
4 changes: 2 additions & 2 deletions examples/gps_simpletest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@
gps.timestamp_utc.tm_hour, # not get all data like year, day,
gps.timestamp_utc.tm_min, # month!
gps.timestamp_utc.tm_sec))
print('Latitude: {0:.6f} degrees'.format(gps.latitude))
print('Longitude: {0:.6f} degrees'.format(gps.longitude))
print('Latitude: {} degrees {:.4f} minutes'.format(gps.latitude[0], gps.latitude[1]))
print('Longitude: {} degrees {:.4f} minutes'.format(gps.longitude[0], gps.longitude[1]))
print('Fix quality: {}'.format(gps.fix_quality))
# Some attributes beyond latitude, longitude and timestamp are optional
# and might not be present. Check if they're None before trying to use!
Expand Down