pass additonal pins as arguments #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
reviewed
Dec 19, 2020
| displayio.release_displays() | ||
| if spi is None: | ||
| spi = board.SPI() | ||
| if cs is None: | ||
| cs = board.D9 | ||
| if dc is None: | ||
| dc = board.D10 |
There was a problem hiding this comment.
was the default for dc here removed intentionally?
There was a problem hiding this comment.
No -- I will restore it -- surprised it worked OK on the stm32...
There was a problem hiding this comment.
restored - thanks for catching that.
FoamyGuy
requested changes
Dec 19, 2020
There was a problem hiding this comment.
I think we do want the dc default. I needed to add this back in to be able to use the no parameter constructor keyboard_featherwing.KeyboardFeatherwing() on a Feather Sense.
if dc is None:
dc = board.D10
I tested your changes successfully with UM Feather S2 and it's working well.
FoamyGuy
approved these changes
Dec 19, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 20, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.13.1 from 1.13.0: > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#66 from jerryneedell/jerryn_keyboard_featherwing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #65
add argument for passing ts_cs, sd_cs, neopixel_pin as arguments
keep defaults as expected.
tested default settings with feather_stm32f405_express
tested non-standard settings with umfeathers2
I had to disable pylint (too-many-arguments)