Skip to content

Add type annotations #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Add type annotations #27

merged 1 commit into from
Mar 17, 2022

Conversation

tekktrik
Copy link
Member

Resolves #25 by adding type annotations! Also minor update to method docstrings that mentioned returning tuples when they were in fact returning lists.

@tekktrik tekktrik requested a review from a team March 14, 2022 17:18
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @tekktrik

@FoamyGuy FoamyGuy merged commit a2b0433 into adafruit:main Mar 17, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 17, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_FXOS8700 to 2.1.12 from 2.1.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_FXOS8700#27 from tekktrik/doc/add-typing
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_Colorsys to 2.0.4 from 2.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Colorsys#19 from tekktrik/doc/add-typing
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_HTTPServer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
2 participants