'_SPI_OPCODE_RDID' is not defined (Jetson Nano)

[ADV-LUT]

I'm trying to run the SPI fram breakout board with the Jetson nano and always get the following error message when I'm running the example.

Traceback (most recent call last):
File "fram_spi_simpletest.py", line 11, in <module>
fram = adafruit_fram.FRAM_SPI(spi, cs)
File "/home/adves/.local/lib/python3.6/site-packages/adafruit_fram.py", line 301, in __init__
spi.write(bytearray([_SPI_OPCODE_RDID]))
NameError: name '_SPI_OPCODE_RDID' is not defined
Exiting...
Cleaning up pins

[ladyada]

thats odd because its defined right above
https://github.com/adafruit/Adafruit_CircuitPython_FRAM/blob/master/adafruit_fram.py#L291
@jerryneedell or @makermelissa have y'all used this library recent

[jerryneedell]

@ladyada Just tried one on a feather_nrf5280_express -- no problem.

[makermelissa]

I haven't used it recently. Perhaps this is something related specifically to the Jetson Nano.

[ladyada]

@ADV-LUT how are you installing? what version python are you running

[ADV-LUT]

@ladyada
I also suspect that it could a very special problem with the Jeston Nano. I am also confused because it is defined, I had already checked that.

I have python version 3.6.8

I am grateful for any help.

[caternuson]

It might be a slight syntax error? Need to add a self. or FRAM_SPI. in front of the class variable _SPI_OPCODE_RDID ?

Simple example to demonstrate issue:

class Foo:
    _SOME_VAR = 23

    def foo(self):
        return bytearray([_SOME_VAR])

and then:

$ python3
Python 3.6.8 (default, Oct  7 2019, 12:59:55) 
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import foo
>>> f = foo.Foo()
>>> dir(f)
['_SOME_VAR', '__class__', '__delattr__', '__dict__', '__dir__', '__doc__', '__eq__', '__format__', '__ge__', '__getattribute__', '__gt__', '__hash__', '__init__', '__init_subclass__', '__le__', '__lt__', '__module__', '__ne__', '__new__', '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__sizeof__', '__str__', '__subclasshook__', '__weakref__', 'foo']
>>> f.foo()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "foo.py", line 5, in foo
    return bytearray([_SOME_VAR])
NameError: name '_SOME_VAR' is not defined
>>> 

same for CP:

Adafruit CircuitPython 4.1.0 on 2019-08-02; Adafruit ItsyBitsy M4 Express with samd51g19
>>> import foo
>>> f = foo.Foo()
>>> dir(f)
['__class__', '__dict__', '__module__', '__qualname__', 'foo', '_SOME_VAR']
>>> f.foo()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "foo.py", line 5, in foo
NameError: name '_SOME_VAR' is not defined
>>>

[makermelissa]

That makes sense.

[ladyada]

@ADV-LUT please try the example code as is

[ADV-LUT]

I have the same result/issue as @caternuson with the sample code on the Jetson Nano.

And how can I fix that?

[caternuson]

@ADV-LUT Do you know how to make pull requests? This looks like a pretty simple issue that would make for a good first one.

[ADV-LUT]

@caternuson I have not made a pull request yet, but I would like to do it. I've just read how it works, but have not quite understood.
And I still do not fully understand how and where to change something now to fix the bugs.

And if I understand that correctly, the pull request is there for me, that my changes are taken over in the repository. But I do not know, where I have to do changes.

[caternuson]

Check out this guide:
https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github/overview

[deanpan]

I am running similar issue on Raspberry Pi.

name '_SPI_OPCODE_RDID' is not defined

Thanks!

pi@raspberrypi:~ $ python3
Python 3.7.3 (default, Jul 25 2020, 13:03:44)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

import board
import busio
import digitalio
import adafruit_fram
spi = busio.SPI(board.SCK, board.MOSI, board.MISO)
cs = digitalio.DigitalInOut(board.D6)
fram = adafruit_fram.FRAM_SPI(spi, cs)
Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python3.7/dist-packages/adafruit_fram.py", line 323, in init
spi.write(bytearray([_SPI_OPCODE_RDID]))
NameError: name '_SPI_OPCODE_RDID' is not defined

[caternuson]

Reopening.

I think this works on CircuitPython and not elsewhere because of use of const(). Can re-create same issue on a RPI:

pi@raspberrypi:~ $ python3
Python 3.7.3 (default, Dec 20 2019, 18:57:59) 
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import board
>>> import busio
>>> import digitalio
>>> import adafruit_fram
>>> spi = busio.SPI(board.SCK, board.MOSI, board.MISO)
>>> cs = digitalio.DigitalInOut(board.D6)
>>> fram = adafruit_fram.FRAM_SPI(spi, cs)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/pi/blinka/lib/python3.7/site-packages/adafruit_fram.py", line 330, in __init__
    spi.write(bytearray([_SPI_OPCODE_RDID]))
NameError: name '_SPI_OPCODE_RDID' is not defined
>>>