Skip to content

Added WiFi Manager and changed examples #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 15, 2019
Merged

Added WiFi Manager and changed examples #4

merged 10 commits into from
Feb 15, 2019

Conversation

makermelissa
Copy link
Collaborator

@makermelissa makermelissa commented Feb 15, 2019 •
edited
Loading

I added a WiFi manager to handle a lot of the connection details and change the status light on the board. I also updated Jerry's examples to make use of the WiFi Manager.

jerryneedell
jerryneedell reviewed Feb 15, 2019
View reviewed changes
jerryneedell
jerryneedell reviewed Feb 15, 2019
View reviewed changes
@jerryneedell
Copy link
Contributor

This looks great. I’d prefer to be able to test it before approval. I should be able to do that tomorrow morning.

@makermelissa
Copy link
Collaborator Author

Ok done. I also added the examples to the RTD examples file.

@makermelissa
Copy link
Collaborator Author

I decided to add params to the DocStrings just to polish it up a little more.

@jerryneedell
Copy link
Contributor

tested post and cheerlights examples on metro_m4_espress with Huzzah ESP32 and feather_nrt52840_express with Espressif DevKit -- both worked great!

jerryneedell
jerryneedell approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! Thanks!

ladyada
ladyada approved these changes Feb 15, 2019
View reviewed changes
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elegant! well done :) thanks @makermelissa

@ladyada ladyada merged commit daa8dab into adafruit:master Feb 15, 2019
@ladyada
Copy link
Member

ladyada commented Feb 15, 2019

@kattni wanna bump this too?

@kattni
Copy link
Contributor

kattni commented Feb 15, 2019

@ladyada @makermelissa has been keeping up with bumping libs like a champ! But I can take care of this one to get it done!

@makermelissa
Copy link
Collaborator Author

Is bumping the same thing as pushing a release in this case?

@ladyada
Copy link
Member

ladyada commented Feb 15, 2019

ooh pardon - ok flip a coin :) yes when i say 'bump' i mean you increase the semver and release

@kattni
Copy link
Contributor

kattni commented Feb 15, 2019

@makermelissa Yep! That's exactly what it is :)

@kattni
Copy link
Contributor

kattni commented Feb 15, 2019

Already released!

@makermelissa
Copy link
Collaborator Author

Ah, ok. Thanks.

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 15, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@5ea5ed2)
c307bfe 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.1.0 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#4 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Register to 1.5.1 from 1.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Register#21 from ladyada/master
@anecdata anecdata mentioned this pull request Apr 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

@jerryneedell jerryneedell jerryneedell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@makermelissa @jerryneedell @ladyada @kattni