Skip to content

Add "consider-using-f-string" to .pylintrc disable #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add "consider-using-f-string" to .pylintrc disable #1

wants to merge 1 commit into from

Conversation

tekktrik
Copy link
Member

Tripped up pre-commit so I disabled it in .pylintrc

@tekktrik tekktrik added the documentation Improvements or additions to documentation label Mar 29, 2022
@tekktrik tekktrik requested a review from a team March 29, 2022 15:08
@tekktrik tekktrik changed the title Add "consider-using-f-string" to .pylintrc Add "consider-using-f-string" to .pylintrc disable Mar 29, 2022
dhalbert
dhalbert requested changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use f-strings where it is complaining, and f-strings are enabled on the port where this is used, so could you just change the code?

@tekktrik
Copy link
Member Author

Sounds good, I'll close this and open a new PR with so the commit history is cleaner

@tekktrik tekktrik closed this Mar 29, 2022
@tekktrik tekktrik mentioned this pull request Mar 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert requested changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tekktrik @dhalbert