Skip to content

Updated background color handling for label #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jun 6, 2020
Merged

Updated background color handling for label #49

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
fb0cfee
added rectangular bitmap tilegrid as background color
Jun 4, 2020
30e5a24
Fixed insert error that could cause additional bitmap insertions, add…
Jun 5, 2020
a51392c
added example showing background color padding
Jun 5, 2020
c41ca13
ran black
Jun 5, 2020
7464d08
ran black
Jun 5, 2020
ee5a5ab
Deleted unnecessary comments
Jun 5, 2020
ae57758
Hid the following variables inside the class (background_tight and pa…
Jun 5, 2020
5c11366
deleted unnecessary variable
Jun 5, 2020
a90c00e
ran black for reformatting
Jun 5, 2020
04ba5b3
updated to resolve pylint formatting warmings
Jun 5, 2020
c6951dc
ran black again after pylint changes
Jun 5, 2020
a52eede
broke out a separate function for _create_background_box
Jun 5, 2020
9f4c2df
updated missing variable to reference back to self instance variables
Jun 5, 2020
a171421
reduced quantity of class instance variables: put padding into a tuple
Jun 5, 2020
b49ec93
checking the impact of variables on pylint error
Jun 5, 2020
dcd4662
eliminated a local variable 'bounds'
Jun 5, 2020
f8c69db
ran black for formatting
Jun 6, 2020
2efbd77
removed comments and re-ran black
Jun 6, 2020
1be4aa3
Updated _padding example to meet pylint requirements
Jun 6, 2020
93130c4
Updated sequence of import statements to meet pyline requirement
Jun 6, 2020
05bd0ad
deleted unnecessary comment
Jun 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion adafruit_display_text/label.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def __init__(
if not max_glyphs and not text:
raise RuntimeError("Please provide a max size, or initial text")
if not max_glyphs:
max_glyphs = len(text)
max_glyphs = len(text) + 1 # add one for the background bitmap tileGrid
super().__init__(max_size=max_glyphs, **kwargs)
self.width = max_glyphs
self._font = font
Expand Down Expand Up @@ -188,6 +188,18 @@ def _update_text(self, new_text): # pylint: disable=too-many-locals
self._text = new_text
self._boundingbox = (left, top, left + right, bottom - top)

background_bitmap = displayio.Bitmap(
self._boundingbox[2], self._boundingbox[3], 1
)

tile_grid = displayio.TileGrid(
background_bitmap, pixel_shader=self.palette, x=left, y=top
)

self.insert(
0, tile_grid
) # add background bitmaps to the bottom layer of the group

@property
def bounding_box(self):
"""An (x, y, w, h) tuple that completely covers all glyphs. The
Expand Down