-
Notifications
You must be signed in to change notification settings - Fork 39
Adding ScrollingLabel #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One item for consideration:The keyword argument Perhaps making the this a subclass |
Thanks for taking a look. I do like this idea better to use |
After tinkering with it for a bit I'm interested to see if there is a way to do this without having to extend Group instead of Label. If we change the super class it means we would lose all of the "pass through" properties so for setting things like Something like this would no longer work:
we could add "boilerplate" properties that copy all of the Label ones and pass them through to the Label instance but I wonder if there is some way we can avoid needing all of the extra code to re-declare each property. I have changed the argument name to
|
Thanks for the comments about using Label versus Group, and it makes sense. It's awkward to initialize with Oh, and thanks for catching the example code update. I think this is ok for now, so I'll merge it. |
Updating https://github.com/adafruit/Adafruit_CircuitPython_AS7341 to 1.2.3 from 1.2.2: > Consolidate Documentation sections of README > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#22 from Neradoc/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_VCNL4010 to 0.11.0 from 0.10.10: > Consolidate Documentation sections of README > Merge pull request adafruit/Adafruit_CircuitPython_VCNL4010#22 from stonehippo/proximity_frequency_read_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_BroadcastNet to 0.12.0 from 0.11.1: > Consolidate Documentation sections of README > Merge pull request adafruit/Adafruit_CircuitPython_BLE_BroadcastNet#27 from tekktrik/feature/use-ble-consts Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Adafruit to 1.4.0 from 1.3.3: > Consolidate Documentation sections of README > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Adafruit#19 from tekktrik/feature/use-ble-consts Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_LYWSD03MMC to 1.0.5 from 1.0.4: > Consolidate Documentation sections of README > Merge pull request adafruit/Adafruit_CircuitPython_BLE_LYWSD03MMC#4 from tekktrik/doc/add-typing Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 5.1.3 from 5.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#76 from tekktrik/doc/consolidate-readme > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#75 from tekktrik/doc/add-typing Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.22.0 from 2.21.4: > Post-patch cleanup > Consolidate Documentation sections of README > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#164 from FoamyGuy/scrolling_label Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 2.1.7 from 2.1.6: > Consolidate Documentation sections of README > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#78 from VPTechOps/VPTechOps
This adds a new
ScrollingLabel
that is a fixed-width label that can scroll the text leftward like a marquee.An example has been provided to show the most basic usage.
This component is used in my PyPortal Winamp player project but I figured this piece is generic enough to re-used for other purposes.