Fix anchor point, anchored_position and scale #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think your local repo is behind adafruit master atm. So when this branch got started it's missing some of the newest commits from master. I think I can merge master into this branch and push it here so get it fixed, I'll give that a try. |
# Conflicts: # adafruit_display_text/bitmap_label.py
|
I think that is resolved now. I'll test this out in a bit. Thanks for working on this! |
FoamyGuy
approved these changes
Jan 17, 2021
|
Thanks @FoamyGuy! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 18, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.3.3 from 1.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#36 from FoamyGuy/change_font > Added pre-commit-config file > Added pre-commit and SPDX copyright Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.11.2 from 2.11.0: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#109 from kmatch98/fix_anchor_point > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#107 from FoamyGuy/change_font > Added pre-commit-config file > Added pre-commit and SPDX copyright
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve issue #108 where there was an bug for setting anchor_point and anchored_position.
Main issue was use of getter/setter versus local variable, and sequence of setting any changes to the scale.