implement parameter update for add_values() #50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds an optional parameter
update=True
toadd_values()
. The default keeps the current behavior. Settingupdate=False
results in primitives not being updated, this has to be done manually after adding a number of values.Timing tests with a slightly modified version of
examples/display_shapes_sparkline_simpletest.py
:vs:
The first version maxes out at about 2 seconds after the limit of 40 values is reached, the second version maxes out at 0.2 seconds. Figures measured with a PyPortal.