Added Type Annotations #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
reviewed
Jun 23, 2022
There was a problem hiding this comment.
@isacben thanks for working on this!
I have a few changes to request, I tried to notate each with a seperate comment. But the main thing is fill and outline properties on many of the shape objects are allowed to be set to None so their type can be Optional[int] instead of just int
Those same properties are repeated a few times in some of the different shapes
|
Hi @FoamyGuy Thank you very much for the feedback! I have corrected most issues locally. The only open issue is the one about the Sparkline (int vs float). I will push the changes when that last part is solved. :) Thank you! |
|
Thanks your your feedback, @FoamyGuy ! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 28, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoTre to 1.2.0 from 1.1.11: > Merge pull request adafruit/Adafruit_CircuitPython_NeoTre#17 from CedarGroveStudios/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.4.6 from 2.4.5: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#49 from isacben/display-shapes-type-annotations > Removed duplicate-code from library pylint disable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added type annotations to the Adafruit_CircuitPython_Display_Shapes library for issue #40