Resolving Issue #8 #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add type hints
Added Union for optional types
Closed
4 tasks
tekktrik
requested changes
Apr 24, 2023
There was a problem hiding this comment.
Looks like this is failing the CI. You can use pre-commit to help fix the issues it's having. You can find information on how to install and use pre-commit here: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code
|
The typing for this repo was completed in #14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PyCon2023, adding Type Hints to function definitions
@tekktrik