Skip to content

Added type hints (Issue #8) #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

jreanah
Copy link

@jreanah jreanah commented Apr 24, 2023

Added type hints to functions and methods in the adafruit_display_notification directory.

@jreanah
Copy link
Author

jreanah commented Apr 24, 2023

@tekktrik

@jposada202020
Copy link

@jreanah The CI is not running automatically in your case, please feel free to ping me in case you need that I start the workflow. Thanks for your contribution :)

@tekktrik
Copy link
Member

It looks like the CI had some issues. You can use pre-commit to fix them and then push the changes. Here's the information on installing and using pre-commit: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code

Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above :)

@tekktrik tekktrik linked an issue Apr 27, 2023 that may be closed by this pull request
4 tasks
@FoamyGuy
Copy link
Contributor

The typing for this repo was completed in #14

@FoamyGuy FoamyGuy closed this Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
4 participants