Implement SH1107 sleep/wake functionality #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: self._awake - stores current state of the display state - property that returns the current state sleep() - method that puts display to sleep wake() - method that wakes display from sleep
Received error during PR submission checks that the rev: fields of the black and reuse-tool repos cannot be mutable objects. Changed rev from "latest" to the current version numbers for each repo.
|
@SAK917 Looks like I forgot to update some stuff on this library. I'll do that tomorrow and then merge it with your fork which will hopefully make your PR pass. |
PR check-in failed Pre-commit hooks test indicating these files had missing copyright and licensing info. Added headers as per @dherrada.
|
@SAK917 Just heard you're working on adding the licenses. That'd be greatly appreciated! If you've got any questions, feel free to ping me |
Addressed the following pylint errors: unused-import [13,1] redefined-builtin [16,1] wrong-import-order [16,1] wrong-import-order [17,1]
@dherrada Happy to do what I can... thanks to a LOT of patience and help from @askpatrickw, I was able to muddle through all the changes the checks flagged. Most were for the supporting files, sorry for all the commits! |
|
@SAK917 Great to see that it's passing! |
askpatrickw
reviewed
Jan 29, 2021
Changed name of display state property from "active" to "is_awake" to clarify it refers to the display state.
Changed property name from state to is_awake Made self._is_awake private
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 6, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#2 from SAK917/main > Added pre-commit and SPDX copyright
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
sleep()andwake()methods and astateproperty to allow users to put the display into a power-saving mode. Uses thebusobject passed to the SH1107 class at initialization to write to the device. Commands for entering and exiting sleep mode derived from the SH1107 datasheet.Tested on a Feather M4 Express and SH1107 FeatherWing OLED 128x64 display.