Add property access for setting waveform and slot.

[caternuson]

Existing approach uses a setter function:

drv.set_waveform(effect, slot)

Change or add a property style access for this. Maybe array access for slot?

drv.waveform[slot] = effect

[ladyada]

yeah that would be more elegant!

[process1183]

I will do this.

[caternuson]

Awesome. Looks like you're up for #8 also. Please do these as separate PR's.

[process1183]

Should the waveform property replace the existing set_waveform() method, or just be added to the DRV2605 class?

[caternuson]

We may end up removing it or making it "private". But for now, just add what's needed for the new interface.

And looking at this again, maybe we just want to do:

drv[slot] = effect

[ladyada]

i like drv[slot] = effect, myself. its elegant and easy to understand.

[tannewt]

I'd suggest doing drv.sequence[slot] = effect since it can include delays as well as waveforms.

[caternuson]

Are you talking about the WAIT feature enabled by bit 7? And then using sequence as a way to indicate that the value of effect is a waveform and not a wait time?

[process1183]

OK, I've made branches for the two proposed solutions. The first implements drv.sequence[slot] = effect in the sequence_property branch. The second implements drv[slot] = effect in the class_index branch. Once we decide which route to take, I'll submit a PR from the chosen branch.

I don't have the DRV2605L board (...yet. I plan to buy one tonight), so I haven't fully tested my changes.

[tannewt]

@caternuson That is what I'm referring to. My point is that not all entries are waveforms, some are pauses. I'm picturing something like:

drv.sequence[0] = Effect(1)
drv.sequence[1] = Pause(0.4)
drv.sequence[2] = Effect(10)

I'm not exactly sure what Effect and Pause would be. They could be functions but then they would read back as ints. If they were objects then the sequence would be understandable when printed back.

@process1183 I don't think your sequence_property code will allow for waits in the current way its written.

[caternuson]

@tannewt I was thinking of something similar. Since it's just a matter of setting the 7th bit, it could be done with:

# to set slot 0 to effect 1
drv.sequence[0] = 1
# to set slot 1 to a wait 0.4 secs (actual delay = 10ms * bits[6:0])
drv.sequence[1] = 0x80 | int(0.4 * 100)

So your Effect and Pause could be module level helper funcs to take care of that bit-foo and math and range check.

def Pause(secs):
    if not 0 <= secs <= 1.27:
        raise ValueError("Out of range.")
    return 0x80 | int(secs *100)

Guess Effect would just be a range check? Not sure what else it would do. Or maybe just don't even have Effect?