Raise NotImplementedError if using non-Express features #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new beta release has already been drafted - this will have to be included in the next release. |
|
I am still testing the latest release. The draft is just the release notes, and I could add more PR's. |
|
@dhalbert If it's not too much of an inconvenience, I would appreciate it being included. It's not crucial though, so if it's an issue, we can wait until the next release to include it. |
dhalbert
approved these changes
Jan 22, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 4, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 4.0.2 from 4.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#87 from kattni/readme-update > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#86 from kattni/express-notimplementederror Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.1.2 from 3.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#87 from adafruit/tannewt-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_MPU6050 to 1.0.3 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_MPU6050#4 from FoamyGuy/master Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.8.8 from 3.8.7: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#69 from adafruit/second-missing-comma > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#68 from adafruit/missing-comma Updating https://github.com/adafruit/Adafruit_CircuitPython_TCS34725 to 3.2.5 from 3.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_TCS34725#26 from adafruit/dherrada-patch-2 Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L0X to 3.2.0 from 3.1.7: > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#14 from jepler/doc-build-fix > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#12 from 2bndy5/master Updating https://github.com/adafruit/Adafruit_CircuitPython_TinyLoRa to 2.0.2 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#25 from Gustavvr/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a way to deal with potentially importing non-Express features when using the Circuit Playground Express and the
expressmodule. Written to be scalable as more features are added to Bluefruit, and more Circuit Playgrounds are added in the future.Requires stack size increase to CircuitPython that is not part of the current beta, it is currently part of master. I would like to get this frozen into the next CircuitPython beta if possible.