Skip to content

Adding examples and content. #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2019

Conversation

kattni
Copy link
Contributor

@kattni kattni commented Jun 7, 2019

These examples have all been tested extensively, as they were copied from the PyCon 2019 example content which was used by many during the conference. I'm adding them here because it makes sense to have more examples available here for this library. As well, the interns working on a CircuitPython VSCode extension may have the opportunity to use this repo to generate a list of the examples.

@kattni kattni requested a review from a team June 7, 2019 18:48
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like one of the files has a typo in the name. Otherwise I’ve personally tested all the examples. :)

@@ -0,0 +1,8 @@
"""This example lights up the first and second NeoPixel, red and blue respectively."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example appears to have a typo in the name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep already caught it. Thanks!

@kattni
Copy link
Contributor Author

kattni commented Jun 7, 2019

Fixing Sphinx issues.

@makermelissa makermelissa merged commit 154b74d into adafruit:master Jun 7, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 8, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 2.1.0 from 2.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#59 from kattni/add-examples-content

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS3502 to 1.0.1 from 1.0.0:
  > fixing lint (again)
  > fixed default example
  > lint fix
  > added updated examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.4.1 from 1.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#52 from brentru/add-pwmout-implementation

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_DS3502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants