Added ability to change touch threshold #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error states `Too many public methods`. The allowed numbers are between 5 and 20. This can be increased in pylint by changing `--max-public-methods=` but this alters it globally.
|
Functionality still being added, however, the method changed significantly in discussion. Closing this PR and starting a new one. |
|
Reopening PR to keep track of previous changes. |
dhalbert
reviewed
Dec 10, 2017
| @@ -66,7 +66,8 @@ def light(self): | |||
| """Light level in SI Lux.""" | |||
| return self._photocell.value * 330 // (2 ** 16) | |||
|
|
|||
| class Express: | |||
|
|
|||
| class Express: # pylint: disable-msg=R0904 | |||
There was a problem hiding this comment.
I think you can do #pylint: disable=too-many-public-methods. That's clearer.
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 10, 2017
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 0.9.1 from 0.9.0: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#20 from kattni/touch-threshold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included image for ReadTheDocs.
Change has been tested by myself and @jedgarpark successfully.