Update charlcd_rpi_rgb_simpletest.py #52
Conversation
-When initializing the class, the last parameter is for the RW feature, however, the previous version of code said it was the lcd_backlight. Renamed it to lcd_rw. -Renamed the comment spelling from Initialise to Initialize. -Changed the comments from "# pin 4" (for example) to "# LCD pin 4" to let the user know we're talking about the LCD pin, not a Pi BOARD/BCM association.
|
@dherrada wanna try this and hte other pr? |
|
@ladyada Sure, I'd love to. |
|
@ladyada Turns out I don't have the right hdmi cable so I can connect the pi to my monitor and connect it to the internet here, so I won't be able to test this until that cable comes in which should be Tuesday or Wednesday |
|
hihi why do you need hdmi? |
|
@ladyada I need hdmi since I haven't used my Pi since I moved into my dorm so it isn't connected to the wifi and the wifi requires you to login through a web browser. After that, I'll just ssh into it. |
|
oh oh i understrand. terrible! |
|
You could try the |
|
huzzah! |
|
@ladyada So apparently the 16x2 display I've got isn't RGB (I thought I bought the RGB one a few months ago to use with the USB adapter, but I guess I ordered the wrong one). Would you like me to see about getting an RGB one or should I hand this off to someone who already has the hardware? |
|
@chadkuester By the way, if you run black and pylint, your code may pass the CI. Guide on doing that here: https://learn.adafruit.com/improve-your-code-with-pylint |
|
@dherrada order an RGB LCD |
|
Tested after merging with the new simpletest and it works fine (the rgb in the old simpletest never really worked for me) and it didn't seem to break anything. |
Updating https://github.com/adafruit/Adafruit_CircuitPython_CharLCD to 3.3.4 from 3.3.3: > Merge pull request adafruit/Adafruit_CircuitPython_CharLCD#52 from chadkuester/patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_CharLCD#51 from taotien/master Updating https://github.com/adafruit/Adafruit_CircuitPython_PM25 to 2.1.0 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_PM25#12 from dglaude/some_pimoroni_improvement
-When initializing the class, the last parameter is for the RW feature, however, the previous version of code said it was the lcd_backlight. Renamed it to lcd_rw.
-Renamed the comment spelling from Initialise to Initialize.
-Changed the comments from "# pin 4" (for example) to "# LCD pin 4" to let the user know we're talking about the LCD pin, not a Pi BOARD/BCM association.