Refactor complete! #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added functionality from monochrome LCD to RGB.
ladyada
requested changes
Nov 21, 2018
|
ok looks good, once travis passes, merge! |
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 22, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_CharLCD to 3.0.1 from 2.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_CharLCD#20 from kattni/cursor-position-fix > Merge pull request adafruit/Adafruit_CircuitPython_CharLCD#19 from kattni/mcp230xx-support Updating https://github.com/adafruit/Adafruit_CircuitPython_Crickit to 2.1.3 from 2.1.2: > DM: update pinmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an API breaker! Will require guides and all existing code be updated.
I tested everything but the RPi examples, but the only thing that's changed since the last time they were tested is the import method. Docstring examples all tested.
Works with basic monochromatic LCD, basic RGB LCD, I2C/SPI mono backpack, RGB shield.
Earlier iteration tested with Pi plate.