Skip to content

Add typing, correct advanced example filename #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 24, 2021
Merged

Add typing, correct advanced example filename #24

merged 6 commits into from
Dec 24, 2021

Conversation

tekktrik
Copy link
Member

PR to originally just correct the advanced example filename, but threw in type hints to address Issue #22 free of charge! The joy of having extra time due to flight delays!

@tannewt tannewt requested a review from a team December 23, 2021 19:16
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Thanks @tekktrik

@FoamyGuy FoamyGuy merged commit e7b19f7 into adafruit:main Dec 24, 2021
@FoamyGuy FoamyGuy mentioned this pull request Dec 24, 2021
24 tasks
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 25, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_CAP1188 to 1.3.2 from 1.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_CAP1188#24 from tekktrik/doc/add-typing
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML6070 to 3.1.9 from 3.1.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_VEML6070#22 from tekktrik/feature/add-typing
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.14.4 from 1.14.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#76 from FoamyGuy/pixelmatrix_fix
  > update rtd py version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants