Skip to content

add ble_lywsd03mmc #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2021
Merged

add ble_lywsd03mmc #295

merged 2 commits into from
Feb 16, 2021

Conversation

dhalbert
Copy link
Contributor

BLE support for Xiaomi thermometer/hygrometer. This is for the factory firmware. There is also an open-source firmware load ("ATC") that will be a separate library.
https://www.adafruit.com/product/4881. Not yet in stock, but others found this library and are using it with their separately-purchased sensors, so we should release it.

@dhalbert dhalbert requested a review from a team February 12, 2021 21:33
Copy link

@askpatrickw askpatrickw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks identical to other add module merges with the exception of the lack of a docs link. I assume the docs will come when the product releases, so approving.

Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhalbert You need to add this to the library list in the docs folder. Take a look at it to get the format needed. Please let me know if you need assistance.

@dhalbert
Copy link
Contributor Author

@kattni Thanks for reminding me. I also removed the word "Service" from a few other libs in there, because the libraries are not really just "Services", or what they are supporting is not exactly a Service.

@dhalbert dhalbert requested review from askpatrickw and kattni and removed request for askpatrickw February 16, 2021 16:09
@kattni
Copy link
Contributor

kattni commented Feb 16, 2021

Thanks @dhalbert!

@kattni kattni merged commit fcd268a into adafruit:master Feb 16, 2021
@dhalbert dhalbert deleted the add-ble-lywsd03mmc branch February 16, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants