Skip to content

Added FakeRequests and PortalBase #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 7, 2020
Merged

Added FakeRequests and PortalBase #282

merged 3 commits into from
Dec 7, 2020

Conversation

makermelissa
Copy link
Collaborator

No description provided.

@makermelissa makermelissa requested a review from a team December 5, 2020 00:17
gamblor21
gamblor21 approved these changes Dec 6, 2020
View reviewed changes
Copy link
Member

@gamblor21 gamblor21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@makermelissa makermelissa changed the title Added FakeRequests Added FakeRequests and PortalBase Dec 7, 2020
@makermelissa
Copy link
Collaborator Author

Whoops, missed the approval. I added PortalBase now too, so it probably needs a re-review.

@makermelissa makermelissa requested a review from a team December 7, 2020 18:09
@kattni kattni merged commit aabd737 into adafruit:master Dec 7, 2020
@makermelissa
Copy link
Collaborator Author

Thanks @kattni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattni kattni kattni approved these changes

@gamblor21 gamblor21 gamblor21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makermelissa @kattni @gamblor21