Skip to content

Added Displayio Drivers for multiple displays #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 23, 2019
Merged

Added Displayio Drivers for multiple displays #160

merged 3 commits into from
Apr 23, 2019

Conversation

makermelissa
Copy link
Collaborator

@makermelissa makermelissa commented Apr 20, 2019 •
edited
Loading

I added the following Displays:
HX8357
ILI9341
SSD1331
SSD1351
ST7735
ST7735R
ST7789

@makermelissa makermelissa requested a review from a team April 20, 2019 22:56
tannewt
tannewt requested changes Apr 22, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ili9341 submodule doesn't match a release. Adabot will rewind to the latest release as is now. Please release the version you have added as a submodule.

Thanks for doing this!

kattni
kattni suggested changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the merge conflict. Thanks!

@makermelissa
Copy link
Collaborator Author

Ok thanks. I’ll update tonight.

@makermelissa
Copy link
Collaborator Author

Thanks for catching that @tannewt. I was wondering if that might happen with the merge conflict since there was a pending PR. Ok, I fixed the merge conflicts and released latest ili9341.

@makermelissa makermelissa requested a review from tannewt April 23, 2019 00:19
@kattni kattni merged commit b1b742e into adafruit:master Apr 23, 2019
@makermelissa
Copy link
Collaborator Author

Thanks @kattni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattni kattni kattni requested changes

@tannewt tannewt Awaiting requested review from tannewt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makermelissa @tannewt @kattni