Skip to content

defer buffer creations until MTU known #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2020
Merged

defer buffer creations until MTU known #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions adafruit_ble_ibbq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,9 @@ class IBBQService(Service):

def __init__(self, service=None):
super().__init__(service=service)
self._settings_result_buf = bytearray(
self.settings_result.packet_size # pylint: disable=no-member
)
self._realtime_data_buf = bytearray(
self.realtime_data.packet_size # pylint: disable=no-member
)
# Defer creating buffers until needed, since MTU is not known yet.
self._settings_result_buf = None
self._realtime_data_buf = None

uuid = StandardUUID(0xFFF0)

Expand Down Expand Up @@ -151,6 +148,10 @@ def temperatures(self):
"""Return a tuple of temperatures for all the possible temperature probes on the device.
Temperatures are in degrees Celsius. Unconnected probes return 0.0.
"""
if self._realtime_data_buf is None:
self._realtime_data_buf = bytearray(
self.realtime_data.packet_size # pylint: disable=no-member
)
data = self._realtime_data_buf
length = self.realtime_data.readinto(data) # pylint: disable=no-member
if length > 0:
Expand All @@ -167,6 +168,11 @@ def battery_level(self):
Results are approximate and may differ from the
actual battery voltage by 0.1v or so.
"""
if self._settings_result_buf is None:
self._settings_result_buf = bytearray(
self.settings_result.packet_size # pylint: disable=no-member
)

self.settings_data = self._REQUEST_BATTERY_LEVEL_MSG
results = self._settings_result_buf
length = self.settings_result.readinto(results) # pylint: disable=no-member
Expand Down