-
Notifications
You must be signed in to change notification settings - Fork 8
Update adafruit_ble_radio.py #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix missing timeout param documentation for receive. (present is receive_full but not receive).
Well that's a super cryptic CI failure... any hints? This is just adding a line to improve the docs. |
It looks like |
@infamy do you need any help finishing up this PR? |
Yeah, i did it directly in github. i dont want to take the time to install
the pre-commit hooks for a minor documentation correction.
Alex
…On Wed, Feb 16, 2022 at 4:40 PM Patrick ***@***.***> wrote:
@infamy <https://github.com/infamy> do you need any help finishing up
this PR?
—
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABP6D45IHWJURFGAPEFHXTU3Q7YXANCNFSM5OCFULAQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the formatter and pushed the result to this branch and it's passing now.
This change looks good to me. Thanks for the docs improvement @infamy.
Updating https://github.com/adafruit/Adafruit_CircuitPython_AHTx0 to 1.0.10 from 1.0.9: > Fixed readthedocs build > Merge pull request adafruit/Adafruit_CircuitPython_AHTx0#11 from tammymakesthings/issue9-add-type-annotations > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_AMG88xx to 1.2.11 from 1.2.10: > Fixed readthedocs build > Merge pull request adafruit/Adafruit_CircuitPython_AMG88xx#35 from tammymakesthings/issue32-add-type-annotations > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_AS7341 to 1.2.5 from 1.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#27 from tekktrik/doc/reveal-gain-class > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#25 from tammymakesthings/update-requirements-for-typing Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X_RVC to 1.0.8 from 1.0.7: > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x_RVC#5 from tekktrik/doc/add-typing > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 4.1.3 from 4.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#51 from lstein/decode-bug-fix > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Radio to 0.5.1 from 0.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Radio#22 from infamy/patch-1
Fix missing timeout param documentation for receive. (present is receive_full but not receive).