Defer packet size #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
force-pushed
the
defer-packet_size
branch
from
cc81102 to
ecaed4f
Compare
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 6, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.3.3 from 3.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#98 from brentru/update-simpletest Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Cycling_Speed_and_Cadence to 1.1.2 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Cycling_Speed_and_Cadence#4 from dhalbert/defer-packet_size Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Heart_Rate to 1.1.2 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Heart_Rate#8 from dhalbert/doc-and-pypi > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Heart_Rate#9 from dhalbert/defer-packet_size Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_iBBQ to 1.2.1 from 1.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_iBBQ#2 from dhalbert/defer-packet_size Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_MIDI to 1.0.0 from 0.8.0: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_MIDI#3 from dhalbert/delay-packet_size > build.yml: add black formatting check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes in hand with adafruit/circuitpython#2799. Don't allocate packet buffer until we're connected. At that time we know the MTU of the connection and therefore know how big the packet buffer can be.
Some of these commits will go away when/if #8 is accepted.