update example to use .packet_size #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhalbert Do you think this might work as a a fix to CircuitPython_Apple_Media? I'll test this pr in a few hours if no one else has by then |
[answering in BaseCamp thread] |
|
@dherrada Did you test this and it worked? If so can you approve, or if you can't, I'll just merge. |
|
@dhalbert I haven’t tested this yet although I should do that before pyloton gets merged. Will test in 2 mins |
|
Works great! |
evaherrada
approved these changes
Feb 25, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 25, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Heart_Rate to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Heart_Rate#4 from dhalbert/packet-size Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.2.0 from 1.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#19 from FoamyGuy/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_HTS221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove workaround for bad
.packet_sizethat is fixed in CircuitPython 5.0.0-beta.5@dherrada @dglaude Note this fix.