Skip to content

Initial version #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 28, 2020
Merged

Initial version #1

merged 6 commits into from
Jan 28, 2020

Conversation

dhalbert
Copy link
Contributor

Initial version of BLE Heart Rate Service. Tested with Scoshe Rhythm+ Armband Heart Rate Monitor.

@jedgarpark This is very similar to what I sent you. The filename is now ...heart_rate instead of ..._heartrate, and there are some minor changes to satisfy pylint.

@dhalbert dhalbert requested a review from jedgarpark January 28, 2020 03:52
Copy link

@siddacious siddacious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak for the code but the actions related stuff looks good

@dhalbert dhalbert force-pushed the master branch 3 times, most recently from 6f5dc4f to 6e3a3f8 Compare January 28, 2020 04:43
@dhalbert dhalbert merged commit 504a673 into adafruit:master Jan 28, 2020
Copy link

@siddacious siddacious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants