Minor tidying around use of Bluetooth Comany ID value

[kevinjwalters]

I noticed:

• the code makes us of Google's Bluetooth Company ID (0xfeaa) but doesn't describe it as such and it's duplicated as a little-endian 16bit value, embedded in a cryptic looking prefix string:

  • Adafruit_CircuitPython_BLE_Eddystone/adafruit_ble_eddystone/__init__.py

    Line 46 in d8c43de

    uuid = StandardUUID(0xFEAA)

  • Adafruit_CircuitPython_BLE_Eddystone/adafruit_ble_eddystone/uid.py

    Line 45 in d8c43de

    prefix = b"\x03\x03\xaa\xfe\x04\x16\xaa\xfe\x00"

    and

    Adafruit_CircuitPython_BLE_Eddystone/adafruit_ble_eddystone/url.py

    Line 98 in d8c43de

    prefix = b"\x03\x03\xaa\xfe\x04\x16\xaa\xfe\x10"

[kevinjwalters]

Improvements around prefix feature in adafruit/Adafruit_CircuitPython_BLE#82

[dhalbert]

I replaced prefix with match_prefixes in PR #8 in mid-June. How is the current code?

[kevinjwalters]

The current code does use match_prefixes. I'd only looked at the issue tickets and assumed incorrectly that hadn't been updated.

[dhalbert]

Thanks, I'll close this. I should have noticed this issue was addressed by #8. We deliberately don't ID the company ID, to avoid appearing like an official Google product thing.

Fixed by #8.